Backport set CONTENT_LENGTH for chunked requests #2496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Neat! I'll take a look, we might be able to release this next week along with 5.1. Appreciate you taking the time to follow up and backport this for everyone 🙏 |
…sskiy/puma into TheRusskiy-4-3-chunked-content-length
|
A new 4.3.x release should be out today with this change |
|
Nate the neat! |
|
Released as 4.3.7 |
refi64
added a commit
to refi64/open-build-service
that referenced
this pull request
Dec 12, 2022
Older verisons of Puma had a bug where chunked uploads would result in an empty body: puma/puma#1839 This breaks OBS file uploads that rely chunked transfers, which is generally the standard mechanism used by http clients for uploading large files. A fix was backported to 4.3.7: puma/puma#2496 so this PR updates Puma to the latest 4.3.x release to include this fix. Likely fixes openSUSE#9329. (Note that, if OBS is behind a reverse proxy, this issue may not be observed in the first place, as many reverse proxies will tend to buffer the uploaded data, thus side-stepping the use of chunked uploads entirely.) Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
refi64
added a commit
to refi64/open-build-service
that referenced
this pull request
Dec 12, 2022
Older verisons of Puma had a bug where chunked uploads would result in an empty body: puma/puma#1839 This breaks OBS file uploads that rely chunked transfers, which is generally the standard mechanism used by http clients for uploading large files. A fix was backported to 4.3.7: puma/puma#2496 so this PR updates Puma to the latest 4.3.x release to include this fix. Likely fixes openSUSE#9329. (Note that, if OBS is behind a reverse proxy, this issue may not be observed in the first place, as many reverse proxies will tend to buffer the uploaded data, thus side-stepping the use of chunked uploads entirely.) Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backporting #2287 to 4.3 version
Your checklist for this pull request
[changelog skip]or[ci skip]to the pull request title.[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.Tests passed locally for me.
Rubocop shows a warning for this line, not related to this PR:
https://github.com/TheRusskiy/puma/blob/f3b409c565d67557c04ad37c10a42dd8cad0b655/lib/puma/server.rb#L697