History.md - add links [skip ci] #2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentarg
reviewed
Sep 25, 2020
History.md
Outdated
| * Fix `not_token` being able to be set to true ([#1803]) | ||
| * Fix "Hang on SIGTERM with ruby 2.6 in clustered mode" ([PR [#1741]], [#1674], [#1720], [#1730], [#1755]) | ||
|
|
||
| [PR [#1741]]: https://github.com/puma/puma/pull/1741 |
There was a problem hiding this comment.
Not sure what's wrong, but the rendered file doesn't look good here:
|
I like this 👍 |
MSP-Greg
force-pushed
the
history-link
branch
from
6911188
to
574b5b6
Compare
MSP-Greg
force-pushed
the
history-link
branch
from
574b5b6
to
25d13a0
Compare
|
Sorry, I assumed that the first pass thru it contained no links. Fixed, reformatted some other things, I think it's correct now. |
Please, no. That presupposes a knowledge of markdown, etc... I'll work on the tooling, maybe add it to tools/history or something. I may need to add a json file that contains info about every PR and issue, as one never knows how far back they are, especially with issues. Right now, the file is about 450k. It also requires that one has a token to access the GH GraphQL API. Also, the tooling could go in another Puma repo... |
|
Beautiful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add links to History.md.
Leave the title attribute (date & user)?
I've got code for the first pass, I'll get it working for updates (grabs repo pr/issue info with GraphQL call).
Your checklist for this pull request
[changelog skip]or[ci skip]to the pull request title.[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.