Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split TCP_CORK and TCP_INFO [changelog skip] #2372

Merged
merged 1 commit into from Sep 22, 2020

Conversation

ahorek
Copy link
Contributor

@ahorek ahorek commented Sep 18, 2020

Description

as requested by @headius in #2349

those two functions don't depend on each other

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] or [ci skip] to the pull request title.
  • I have added appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@ahorek ahorek changed the title WIP: split TCP_CORK and TCP_INFO [changelog skip] split TCP_CORK and TCP_INFO [changelog skip] Sep 19, 2020
@headius
Copy link
Contributor

headius commented Sep 20, 2020

👍 May be a moot point for JRuby since you added TCP_INFO support, but I think these should be uncoupled anyway.

@nateberkopec nateberkopec added maintenance waiting-for-review Waiting on review from anyone labels Sep 21, 2020
@nateberkopec nateberkopec merged commit 7928173 into puma:master Sep 22, 2020
@nateberkopec
Copy link
Member

Thanks for the review @headius!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance waiting-for-review Waiting on review from anyone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants