Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation - add version info, misc fixes [ci skip] #2368

Merged
merged 19 commits into from Sep 17, 2020

Conversation

MSP-Greg
Copy link
Member

Description

Recently spent some time with things other than Puma, came back to it, and...

There have been several additions in 5.0.0, so I added the YARD @version tag to all new methods/classes. Added a few @see tags, which link to other methods. The only actual code changes were a typo in two error messages that I did.

Left as separate commits. I can generate docs from this if anyone wants to see the changes...

Separate commits for clarity, obviously should be squashed.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] or [ci skip] to the pull request title.
  • I have added appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@nateberkopec nateberkopec merged commit 038a0d9 into puma:master Sep 17, 2020
This was referenced Sep 17, 2020
@MSP-Greg MSP-Greg deleted the doc branch September 20, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants