Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/helper.rb -TimeoutEveryTestCase - set all timeouts to 45 sec [changelog skip] #2365

Merged
merged 1 commit into from Sep 14, 2020

Conversation

MSP-Greg
Copy link
Member

@MSP-Greg MSP-Greg commented Sep 14, 2020

Description

While working on another PR, I noticed one job (ubuntu-18.04 truffleruby-head) where the log output showed all tests passing, but the job hit the time limit set in the Actions workflow file.

Inspecting the log, it showed three two minute 'pauses' in the log output, which is the current setting in test/helper.rb for non MRI jobs.

A brief look at CI logs seemed to show that the longest test takes approx 30 sec.

This PR changes the settings in TimeoutEveryTestCase to 45 sec for all jobs. Hopefully, this will result in fewer jobs hitting the ten minute time limit, and hence, passing.

Note: testing in my fork with this patch still had jobs timing out (only non MRI jobs). So, there are still problems...

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] or [ci skip] to the pull request title.
  • I have added appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants