TestPumaServerSSLClient - share Context [changelog skip] #2364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working in my fork, JRuby would intermittently have failures/timeouts from the tests in TestPumaServerSSLClient.
These tests can share the SSL Context, so adjust code to create a shared one. Note that the tests in TestPumaServerSSL yield the Context, so sharing them won't work.
Note that CI passed in my fork:
https://github.com/MSP-Greg/puma/runs/1109220969
Your checklist for this pull request
[changelog skip]
or[ci skip]
to the pull request title.[ci skip]
to the title of the PR.#issue
" to the PR description or my commit messages.