Puma MiniSSL Filehandle Leak

[JohnPhillips31416]

Describe the bug
When running with JRuby and configured with a Puma::MiniSSL::Context with a keystore file path MiniSSL will open 2 filehandles to the keystore file on every SSL REST request. These filehandles do not get closed until a subsequent Java garbage collection occurs.

Expected behavior
Ideally MiniSSL should only open/read the keystore file once, not on each https request. A simpler fix is just to properly close the 2 FileInputStream objects after use.

puma/ext/puma_http11/org/jruby/puma/MiniSSL.java

Line 148 in 477479a

ks.load(new FileInputStream(keystoreFile), password);

puma/ext/puma_http11/org/jruby/puma/MiniSSL.java

Line 149 in 477479a

ts.load(new FileInputStream(keystoreFile), password);

Desktop (please complete the following information):

• OS: Linux
• Puma Version 4.3.5

[nateberkopec]

Nice catch. Want to open a PR with your change?

[JohnPhillips31416]

I'll do this when I have time, we should probably refactor so the keystore is only read from disk once.

[JohnPhillips31416]

fix is here #2302

[MSP-Greg]

Closed by #2302