Added nakayoshi_fork option.
#2256
Conversation
|
the nakayoshi gem does a max of 4 times, not sure if that's a theoretical ideal to also use here |
Reduce memory usage in preloaded cluster-mode apps by GCing before fork and compacting, where available.
|
True, changed. I'm going to leave out the full algorithm for now because a) license issues w/incorporating someone else's MIT-licensed algo that I don't feel like dealing with and b) compact implies GC, so we could probably GC fewer times in that case. I want to punt on all the perf issues and possible optimizations until we figure out if this even decreases memory usage at all, if it does then we can deal with these issues. |
| # also increase time to boot and fork. See your logs for details on how much | ||
| # time this adds to your boot process. For most apps, it will be less than one | ||
| # second. | ||
| def nakayoshi_fork(enabled=false) |
There was a problem hiding this comment.
Why are we defaulting this to false? It seems weird that adding this in my config does nothing:
nakayoshi_fork
I have to
nakayoshi_fork(true)
Was this intentional or can we change the default?
There was a problem hiding this comment.
Thaaaaat would be a bug
There was a problem hiding this comment.
Maybe that’s why there was so little change in CodeTriage
Reduce memory usage in preloaded cluster-mode apps by GCing before
fork and compacting, where available.
Description
Please describe your pull request. Thank you for contributing! You're the best.
Your checklist for this pull request
[changelog skip]the pull request title.[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.