Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline commandline tools with config #2247

Open
anon987654321 opened this issue May 2, 2020 · 4 comments
Open

Streamline commandline tools with config #2247

anon987654321 opened this issue May 2, 2020 · 4 comments
Labels

Comments

@anon987654321
Copy link

Problem

  • Commandline tools puma and pumactl are seemingly unnecessary duplicates
  • They share similar options but under different names
  • Some options available to one are not available to the other
  • Makes OS-level daemon management via pumactl difficult without also being dependent upon puma.rb

Solution

All available options in the config file should also be made available to puma and pumactl under the same naming scheme.

pumactl should also be replaced by a wrapper around puma that adds the daemon management options on top of the existing feature set.

Alternatives

Ditching pumactl altogether in favor of puma combined with a kill tool like zap for managing stops and restarts.

Additional context

#2242 #2243 #2244

@nateberkopec
Copy link
Member

They share similar options but under different names

This I definitely would be happy to look at individual cases and fix. I agree that the options should be as similar as possible.

pumactl should also be replaced by a wrapper around puma that adds the daemon management options on top of the existing feature set.

This I am not so sure. Pumactl has always been the "remote control" of Puma, and bin/puma has always been the "binary". I don't think they are unnecessary duplicates.

@MSP-Greg
Copy link
Member

MSP-Greg commented May 5, 2020

Don't recall anyone asking for it, but given that MRI Puma requires compiling and also nio4r, Puma::ControlCLI could even be released as a gem...

@dentarg
Copy link
Member

dentarg commented Oct 29, 2020

@nateberkopec should we close this issue? I think the individual cases you asked for can be new issues. It is not clear to me what needs to be done to close this issue (as stated, there is reasoning behind having two tools (puma and pumactl).

@nateberkopec
Copy link
Member

what needs to be done to close this issue

Someone can take a look at puma vs pumactl options and decide if any of them need to be changed so as to align with the other tool.

I'll mark as contrib-wanted.

@nateberkopec nateberkopec changed the title Streamline commandline tools with config, possibly rewrite pumactl Streamline commandline tools with config Apr 28, 2021
@nateberkopec nateberkopec added this to the 6.0.0 milestone Apr 28, 2021
@nateberkopec nateberkopec removed this from the 6.0.0 milestone Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants