Run tests on TruffleRuby, all tests pass now #2198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Otherwise they could GC in the middle of the test, and the files could then be deleted.
* There is no point to decode the bytes since we are closing the socket in Puma::MiniSSL::Socket#close. * Also, calling #engine_read_all might cause further SSL errors, which could hide the first SSL error. This notably happens in TestPumaServerSSLClient#test_verify_fail_if_no_client_cert if the server is faster than the client. The error in that case is "System error: Success - 0 (Puma::MiniSSL::SSLError)" which is not actually an error, but there is also nothing to read further from SSL.
| @port = 3307 if @port == 3306 # MySQL on Actions | ||
| @port | ||
| } | ||
| TCPServer.open('127.0.0.1', 0) do |server| |
* 60 doesn't seem enough in CI for TestThreadPool#test_trim on TruffleRuby.
eregon
force-pushed
the
run-tests-on-truffleruby
branch
from
4af1bda
to
122a1ee
Compare
* This should speed up CI a bit for those jobs.
eregon
force-pushed
the
run-tests-on-truffleruby
branch
from
122a1ee
to
646d73a
Compare
|
Thanks so much @eregon and Shopify! 🎉 |
eregon
commented
Mar 29, 2020
| :eagain | ||
| else | ||
| :drop | ||
| end |
There was a problem hiding this comment.
For the record, this might be related to a bug in OpenSSL, mentioned in ruby/openssl#355 (comment)
Anyway, it seems safer to not call to SSL anymore if we are in such a state, as this commit does.
This was referenced Oct 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the reliability of tests and as a result all tests now pass on TruffleRuby.
One extra fix was needed in TruffleRuby (oracle/truffleruby@2e046e4).
A major part of getting TruffleRuby to pass Puma's tests was by done by Shopify contributors to TruffleRuby (especially the signal stuff).
Since tests pass on TruffleRuby, I also moved TruffleRuby along with other tested versions in CI, so failures are no longer ignored.
I ran the CI twice in GitHub Actions and it passed in both cases.
cc @chrisseaton @nateberkopec
Your checklist for this pull request