Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the JRuby tests that skip/fail for no good reason #2183

Closed
nateberkopec opened this issue Mar 14, 2020 · 2 comments
Closed

Fix the JRuby tests that skip/fail for no good reason #2183

nateberkopec opened this issue Mar 14, 2020 · 2 comments

Comments

@nateberkopec
Copy link
Member

The only tests we should be skipping on JRuby are the ones where the feature isn't supported by the platform. I had to add a bunch of skips to get us back to green (skip_on). We should remove these test-by-test.

I'm 99% confident that the problem in all these cases is just racy tests rather than code, but the only way to be sure is a passing test.

@dentarg
Copy link
Member

dentarg commented Mar 18, 2020

Related issue about JRuby build failures (back when tests ran on Travis CI): #1982

@dentarg
Copy link
Member

dentarg commented Mar 18, 2020

Here are the recent commits that skipped tests for JRuby: 00e20d8...e42d3a6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants