New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log binding on http:// for TCP bindings to make it clickable #2167
Conversation
Looks like you missed a spot or two, but right idea 👍 I'm not sure why it doesnt log the fail correctly, but it looks like failures are coming from TestBinder, perhaps |
Ah thanks @nateberkopec, I will have another look 👍 |
Hey @ChrisBr - did you get stuck? |
I looked at this locally today but I'm getting weird issues with tests and output that I think are unrelated. |
Hey sorry, was a little bit busy! Will have another look tonight. |
Something really weird is going on here, as trying to change the tests from tcp:// to http:// for me causes the tests to crash.
|
Hey, I could take this. I ran tests and it works ok on my machine with macOS. Shall I make a new pull request with the branch synced with the master? |
Please do! |
Please feel free to take this over. Sorry for the delays! |
Description
Fix #2166
Your checklist for this pull request
[changelog skip]
the pull request title.[ci skip]
to the title of the PR.#issue
" to the PR description or my commit messages.