Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.3.2 broke rails system tests that use Devise sign_in helper #2131

Closed
jeffblake opened this issue Feb 27, 2020 · 1 comment
Closed

4.3.2 broke rails system tests that use Devise sign_in helper #2131

jeffblake opened this issue Feb 27, 2020 · 1 comment

Comments

@jeffblake
Copy link

I imagine the security fix in version 4.3.2 is rejecting the header that the devise helper adds to the request?

This is the helper being used in ApplicationSystemTestCase:
https://github.com/heartcombo/devise/blob/master/lib/devise/test/integration_helpers.rb

Trying to follow that code, it goes somewhere in here https://github.com/wardencommunity/warden/blob/997055a511ae65b1d0b84112f1f35813e3f4cd84/lib/warden/proxy.rb#L170 then elsewhere

Not sure the best solution, can you skip this security check in RACK_ENV test?
@bmclean bmclean mentioned this issue Feb 27, 2020
Closed
@nateberkopec
Copy link
Member

Merging to #2132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeffblake @nateberkopec