Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument requests count #2106

Merged
merged 5 commits into from Feb 11, 2020

Conversation

ylecuyer
Copy link
Contributor

@ylecuyer ylecuyer commented Jan 25, 2020

Description

For monitoring purpose and in order to create a puma worker killer style plugin (which restart workers after 10k requests) I need to add instrumentation for requests count

I have not yet added test nor the entry in HISTORY.md as I want to be sure this PR wont be rejected before working on this.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] the pull request title.
  • I have added appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@nateberkopec
Copy link
Member

LGTM, I think this will work.

@wjordan
Copy link
Contributor

wjordan commented Feb 7, 2020

This PR seems similar to #2061, in fact the code change is nearly identical. That PR is still in-progress because test coverage was requested (#2061 (review)).

@nateberkopec
Copy link
Member

I have no problem merging either, just a matter of who figures out the testing issues first 😆

@ylecuyer
Copy link
Contributor Author

Required tests have been added ;)

@nateberkopec
Copy link
Member

Wünderbar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants