Update pumactl to remove development as default environment

[AndrewSpeed]

What changed?

This PR:

• removes the default environment of development from pumactl
• defaults to development when searching for config files to load, if one is not provided to pumactl
• passes the value passed to the environment option over RACK_ENV to pumactl, if provided

fixes #2023

[composerinteralia]

🎉

[composerinteralia]

Instead of mutating the environment, which could lead to order-dependent test failures if there is another test that unexpectedly relies on a specific environment variable being set, it might be nice to reuse the with_env helper.

Or, if we are OK with adding an additional dependency, at thoughtbot we often use climate_control for this sort of thing. It has the advantage of being threadsafe, which might help if we plan to parallelize these tests.

[nateberkopec]

Let's just use with_env for now, but keep our eyes on climate_control for the future.

[composerinteralia]

I think some of this file manipulation makes the test a bit more difficult to read. What do you think about extracting a helper like:

def with_config_file(path_to_config, port)
  path = Pathname.new(path_to_config)
  Dir.mktmpdir do |tmp_dir|
    Dir.chdir(tmp_dir) do
      FileUtils.mkdir(path.dir)
      File.open(path, "w") { |f| f << "port #{port}" }
      yield
    end
  end
end

def test_environment_specific_config_file_exist
  port = 6002
  path_to_config = "config/puma.rb"

  with_config_file(path_to_config, port) do
    control_cli = Puma::ControlCLI.new ["-e", "production", "halt"]
    assert_equal path_to_config,
      control_cli.instance_variable_get("@config_file")
  end
end

[AndrewSpeed]

This seemed like the most appropriate place for this file, but let me know if there's another convention I should be following

[nateberkopec]

Works for me!

[nateberkopec]

Solid PR, thanks for the contribution 👍