Configuration: Get environment from RAILS_ENV, too #2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
force-pushed
the
make-puma-heroku-configuration-default
branch
from
ac9f3d7
to
cf6412a
Compare
olleolleolle
force-pushed
the
make-puma-heroku-configuration-default
branch
3 times, most recently
from
5ce7365
to
7f2e147
Compare
olleolleolle
commented
Oct 10, 2019
| ENV.delete 'RACK_ENV' | ||
|
|
||
| Puma::CLI.new ["--environment", @environment] | ||
|
|
||
| assert_equal ENV['RACK_ENV'], @environment | ||
| assert_equal @environment, ENV['RACK_ENV'] |
There was a problem hiding this comment.
This improves the output on failing - the order of arguments is: assert_equal exp, actual
|
@olleolleolle friendly nudge/reminder to fix the failing tests |
|
Huh, it's just like I forgot to push one of the files. I'll get to my computer and investigate! |
olleolleolle
force-pushed
the
make-puma-heroku-configuration-default
branch
from
a6545a3
to
9a7f5c3
Compare
olleolleolle
commented
Oct 24, 2019
|
@nateberkopec There, I think this is ready for a Squash now. |
- as well as from RACK_ENV
- this is part of the effort to bring the configuration defaults from
the puma-heroku plugin to Puma
olleolleolle
force-pushed
the
make-puma-heroku-configuration-default
branch
from
d763861
to
596fe0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes configuration defaults.
The default value for environment is also read from
RAILS_ENV, ifRACK_ENVcan't be found.Overview
See #1949
The goal of that Issue is that configuration defaults in puma/puma-heroku move into lib/puma/configuration.rb.