Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSL support for activate_control_app #2015

Closed
Nowaker opened this issue Oct 7, 2019 · 1 comment
Closed

SSL support for activate_control_app #2015

Nowaker opened this issue Oct 7, 2019 · 1 comment
Labels
feature

Comments

@Nowaker
Copy link

Nowaker commented Oct 7, 2019

Valid:

activate_control_app 'tcp://127.0.0.1:9000', auth_token: token

Also valid:

ssl_bind '127.0.0.1', 8443, cert: 'config/cert-dev.pem', key: 'config/cert-dev.key'

Invalid:

activate_control_app 'ssl://127.0.0.1:9000', auth_token: token

[44959] ERROR: Invalid control URI: ssl://127.0.0.1:9000

It would be great for Puma to allow control app to be run behind a TLS certificate to ensure confidentiality of the token.

I know I can TLS-ify it using nginx but so we could use the same argument against ssl_bind :-)
composerinteralia added a commit to composerinteralia/puma that referenced this issue Oct 20, 2019
@composerinteralia
Extract class for building SSL context
f8938f4 
This commit extracts the `MiniSSL::Context` creation into its own
`MiniSSL::ContextBuilder` class along the same lines as in [puma#1989].

This will allow us to reuse this code for adding SSL support to the
control app (issue [puma#2015]). Since we will need the `MiniSSL` require
and check in both places, I moved that into the `ContextBuilder` class
as well.

[puma#1989]: puma#1989
[puma#2015]: puma#2015
composerinteralia added a commit to composerinteralia/puma that referenced this issue Oct 20, 2019
@composerinteralia
Add SSL support for the control app
abc5e72 
This starts to address [puma#2015]. I think we will need to add SSL support
to the control cli as well.

[puma#2015]: puma#2015
@composerinteralia composerinteralia mentioned this issue Oct 20, 2019
Merged
composerinteralia added a commit to composerinteralia/puma that referenced this issue Oct 20, 2019
@composerinteralia
Add SSL support for the control app
fe06bac 
This starts to address [puma#2015]. I think we will need to add SSL support
to the control cli as well.

[puma#2015]: puma#2015
nateberkopec pushed a commit that referenced this issue Oct 21, 2019
@composerinteralia @nateberkopec
Add SSL support for the control app (#2046)
f5ccd03 
* Extract class for building SSL context

This commit extracts the `MiniSSL::Context` creation into its own
`MiniSSL::ContextBuilder` class along the same lines as in [#1989].

This will allow us to reuse this code for adding SSL support to the
control app (issue [#2015]). Since we will need the `MiniSSL` require
and check in both places, I moved that into the `ContextBuilder` class
as well.

[#1989]: #1989
[#2015]: #2015

* Add SSL support for the control app

This starts to address [#2015]. I think we will need to add SSL support
to the control cli as well.

[#2015]: #2015
@nateberkopec
Copy link
Member

Closed by #2046

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Nowaker @nateberkopec