Small JRuby cleanups and optimizations #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use fastARef/fastASet for hash access to avoid context load. * Cache most Java strings used to create headers as ByteLists, to avoid re-encoding and re-constructing the byte[] and ByteList. * Load parse buffer once in field handler. * Eliminate deprecated construction of RaiseException and centralize logic.
Seven fewer objects and no eager lookup of the exception class.
|
See my comment here for reference: #2010 (comment) |
|
Note: This PR does not include the changes from #2010. That patch may not apply cleanly over this one but it's a trivial change. |
There's only ever one implementation of these, so just call them directly.
This was referenced Mar 9, 2021
Merged
This was referenced Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a quick pass over the Http11 class and the generated parser to reduce allocation and other antipatterns.
runtimeandparserfields by passing them into callbacks.The callbacks could also be made into Java lambdas, removing the anonymous classes from the jar file, but that would tie this code to Java 8 or higher. I believe there may still be some JRuby folks with legacy apps on JRuby 1.7 + Java 7. Lambdas versus anon classes would not make any performance difference here.