Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] External term of worker PID broken #1950

Closed
MSP-Greg opened this issue Sep 6, 2019 · 1 comment
Closed

[Bug] External term of worker PID broken #1950

MSP-Greg opened this issue Sep 6, 2019 · 1 comment
Labels
Milestone

Comments

@MSP-Greg
Copy link
Member

MSP-Greg commented Sep 6, 2019

@nateberkopec

I saw you mention that you wanted to release an updated gem. There were a few things gnawing at me:

  1. Concern for whether the 'stuck' workers tests I wrote in test_integration.rb were really correct. It's a tricky thing to mimic/mock, and the current implementation is somewhat indeterminate.

  2. Changing the two stuck worker tests to use a cli based server, which, by not doing so, was interfering with running test_integration.rb parallel.

End result is that an external TERM signal sent to a worker is not being handled correctly. I've got code to fix it, but I tested on top of something similar to PR #1925 in GitHub Actions.

So, I need to bring the 'lib' code back into master, see if it works (it should), and do another PR.

I need to go AFK for a bit... Sorry...

EDIT: Done, see PR #1952

@nateberkopec nateberkopec added this to the 4.2.0 milestone Sep 18, 2019
@nateberkopec
Copy link
Member

Fixed in #1952.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants