Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't mutate global STDOUT/STDERR #1948

Closed
nateberkopec opened this issue Sep 3, 2019 · 2 comments · Fixed by #2486
Closed

Don't mutate global STDOUT/STDERR #1948

nateberkopec opened this issue Sep 3, 2019 · 2 comments · Fixed by #2486
Labels
contrib-wanted feature

Comments

@nateberkopec
Copy link
Member

...but don't break everyone's logging at the same time. #1946
@karloscodes karloscodes mentioned this issue Nov 15, 2020
Merged
8 tasks
@dentarg
Copy link
Member

dentarg commented Nov 15, 2020

Recap

I wonder if the original attempt mostly(?) caused problems for people using demonization: #1906 (comment). Puma doesn't have demonization since version 5, so the code referenced in the linked comment no longer exist.

@dentarg
Copy link
Member

dentarg commented Nov 15, 2020

@ccverak might be good to read through the above PRs/issues if you haven't already

#1906 (comment) mentions that Rails dropped sync = true, there's probably discussions about that in some issue over at https://github.com/rails/rails that one could learn from too

karloscodes pushed a commit to karloscodes/puma that referenced this issue Nov 18, 2020
Avoid mutating stdout and stderr
0f278af 
Uses `flush` after every write if the stdio it is not synchronized.

Closes: puma#1948
karloscodes pushed a commit to karloscodes/puma that referenced this issue Nov 18, 2020
Avoid mutating stdout and stderr
52a563a 
Uses `flush` after every write if the stdio it is not synchronized.

Closes: puma#1948
karloscodes pushed a commit to karloscodes/puma that referenced this issue Nov 18, 2020
Avoid mutating stdout and stderr
bdfb27a 
Uses `flush` after every write if the stdio it is not synchronized.

Closes: puma#1948
karloscodes pushed a commit to karloscodes/puma that referenced this issue Nov 18, 2020
Avoid mutating stdout and stderr
f519468 
Uses `flush` after every write if the stdio it is not synchronized.

Closes: puma#1948
@nateberkopec nateberkopec added feature and removed bug labels Nov 19, 2020
nateberkopec added a commit that referenced this issue Dec 2, 2020
@nateberkopec
Avoid mutating stdout and stderr (#2486)
a284179 
Uses `flush` after every write if the stdio it is not synchronized.

Closes: #1948

Co-authored-by: Nate Berkopec <nate.berkopec@gmail.com>
JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this issue Sep 9, 2022
@nateberkopec @JuanitoFatas
Avoid mutating stdout and stderr (puma#2486)
dd10138 
Uses `flush` after every write if the stdio it is not synchronized.

Closes: puma#1948

Co-authored-by: Nate Berkopec <nate.berkopec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contrib-wanted feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid mutating $stdout and $stderr karloscodes/puma
2 participants
@dentarg @nateberkopec