New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to define a custom formatter for logs #1816
Conversation
@nateberkopec can't this PR be included in the incoming 4.0.1 release ? |
That wouldn't be very SemVer of me, would it? 😆 |
Thanks for keeping this updated, I think we can get it in w/4.1. |
OK great to hear thanks |
I'm cool with this. Needs a test. |
Still needs a test here if it will get into 4.1 |
# Conflicts: # History.md
cbe6da9
to
267d6c7
Compare
I have added some tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not my call, but maybe in the future use
skip NO_FORK_MSG unless HAS_FORK
Prefer 'feature skips' to 'platform skips'...
This PR allows to have a custom formatter for logs through a
log_formatter
dsl inside the configuration fileExample with a new rails app and no
log_formatter
:With the config :