Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report tcp 0 port properly. Fixes #1679 #1786

Merged
merged 3 commits into from Sep 11, 2019
Merged

Report tcp 0 port properly. Fixes #1679 #1786

merged 3 commits into from Sep 11, 2019

Conversation

evanphx
Copy link
Member

@evanphx evanphx commented Apr 25, 2019

No description provided.

@nateberkopec
Copy link
Member

LGTM

@@ -54,7 +56,8 @@ def setup
def test_localhost_addresses_dont_alter_listeners_for_ssl_addresses
@binder.parse(["ssl://localhost:10002?key=#{@key}&cert=#{@cert}"], @events)

assert_equal [], @binder.listeners
assert_equal "ssl://localhost:10002?key=#{@key}&cert=#{@cert}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this PR adds a listener, and why that's "ok".

@nateberkopec nateberkopec modified the milestone: 4.1.0 Jul 28, 2019
@nateberkopec nateberkopec added the waiting-for-changes Waiting on changes from the requestor label Aug 10, 2019
@nateberkopec nateberkopec force-pushed the b-correct-port branch 3 times, most recently from 3827f00 to 5143341 Compare September 11, 2019 07:32
@nateberkopec
Copy link
Member

Oh interesting. When I don't add these to the listeners array, test_sigterm_closes_listeners_on_forked_servers breaks. So that's weird.

@nateberkopec
Copy link
Member

#1120 feels relevant.

@nateberkopec nateberkopec reopened this Sep 11, 2019
@nateberkopec nateberkopec force-pushed the b-correct-port branch 2 times, most recently from 75712a5 to ec44a81 Compare September 11, 2019 11:33
Bonus feature: we now log all localhost addresses that we're bound to,
including ipv6 ones.
@nateberkopec nateberkopec merged commit d9131ca into master Sep 11, 2019
@nateberkopec nateberkopec deleted the b-correct-port branch March 14, 2020 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug waiting-for-changes Waiting on changes from the requestor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants