Allow mutual TLS CA to be set using ssl_bind DSL
#1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you rebase this on master? There have been a few fixes around this code merged lately. |
When using mutual TLS, you must specify the CA certificate chain to use for verifying the peer. Using Puma's `ssl_bind` DSL did not give you the option of doing so, which lead to confusing errors when attempting to use it. Now, when specifying the `verify_mode` as either `peer` or `force_peer`, you can use the DSL to set the `ca` value as needed within the `Binder`. This allows you to use the DSL instead of falling back to the default `bind` syntax via the URI-style configuration pattern.
michaelherold
force-pushed
the
allow-ca-to-be-set-in-bind-dsl
branch
from
489eef4
to
5a92683
Compare
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using mutual TLS, you must specify the CA certificate chain to use
for verifying the peer. Using Puma's
ssl_bindDSL did not give you theoption of doing so, which lead to confusing errors when attempting to
use it.
Now, when specifying the
verify_modeas eitherpeerorforce_peer,you can use the DSL to set the
cavalue as needed within theBinder.This allows you to use the DSL instead of falling back to the default
bindsyntax via the URI-style configuration pattern.