update travis rubies - 2.3.8, 2.4.5, 2.5.3 #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MSP-Greg Oh, great, and now could we also add 2.6.0 in the CI matrix - in this PR? |
|
Being rather *nix/MacOS challenged, might you have time to look at why trunk was failing when it was 2.6.0? IOW, I can add it, but I think it will fail. I believe the failing tests all involve |
|
Perhaps adding the 2.6.0 is worth its own PR. |
|
Update: My findings were: there's a |
|
Thanks. I didn't state it above, but the 2nd commit in this PR fixes the 2.2.10 Travis failure, as shown in your PR #1695... |
MSP-Greg
force-pushed
the
update-travis-ruby
branch
from
c293386
to
7915afc
Compare
|
Thanks a ton! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.