TestPumaUnixSocket used in both test_rack_handler.rb and test_unix_socket.rb

[MSP-Greg]

Double checking test results, I noticed that the test class name TestPumaUnixSocket is used in two different test files.

puma/test/test_rack_handler.rb

Lines 5 to 12 in 72882f2

	class TestPumaUnixSocket < Minitest::Test
	def test_handler
	handler = Rack::Handler.get(:puma)
	assert_equal Rack::Handler::Puma, handler
	handler = Rack::Handler.get('Puma')
	assert_equal Rack::Handler::Puma, handler
	end
	end

puma/test/test_unix_socket.rb

Lines 3 to 15 in 72882f2

	class TestPumaUnixSocket < Minitest::Test
	App = lambda { |env| [200, {}, ["Works"]] }
	Path = "test/puma.sock"
	def setup
	# UNIX sockets are not recommended on JRuby or Windows
	skip_on :jruby, :windows, suffix: " - UNIX sockets are not recommended"
	@server = Puma::Server.new App
	@server.add_unix_listener Path
	@server.run
	end

Because of the setup code in test_unix_socket.rb, the test is skipped on Windows. The test in test_rack_handler.rb does pass on Windows. Not sure whether to rename the class (to what?), move the test method into another class in the file, etc...

System configuration

Puma Master
Rails NA
Ruby more than most

[MSP-Greg]

See PR #1653. Renamed the class in test_rack_handler.rb to TestHandlerGetStrSym, along with another change.

[MSP-Greg]

Closed. See PR #1653 & commit 9de253d.