Add support for --control-url in cli #1487
Conversation
|
Also reported here #1477 |
|
an alternative approach is to simply revert #1416, and write a spec for pumactl. downside being that the options do not match across both interfaces. |
jxa
changed the title
control and control-url options in cli
|
The |
| @@ -220,7 +220,7 @@ def send_signal | |||
| end | |||
|
|
|||
| def run | |||
| start if @command == "start" | |||
| return start if @command == "start" | |||
There was a problem hiding this comment.
Prior to this change, send_request was being called with @command == "start". The control server does not respond to this command, so returns a 404, which then ultimately calls exit 1, making it very difficult to figure out why my test was failing silently. This early return short-circuits all that mess.
|
I'm open to options on how to actually fix the CLI @evanphx @nateberkopec @schneems. Whatever the ultimate decision, I think this is an extremely valuable test which will prevent similar accidental breakage in the future. |
|
/sigh that is, it will be valuable if I can get it to pass reliably on CI |
|
Travis build is failing for ruby 2.1, but not just on this PR. These other PRs have the same failure: |
|
@jxa Sorry for the delay here, I've been taking a break from Ruby. Can you rebase? I think we fixed the build issues. |
|
@nateberkopec sorry I missed your mention somehow! I have rebased, but the appveyor build has failed on 2 versions while trying to compile with ragel. I doubt these are related to my changes. Any advice on how to deal with this issue? |
- deprecate `--control` - add new option `--control-url` - puma#1416 introduced a bug in pumactl the puma cli does not respond to `control-cli` option. On puma it is called `control` - this commit puma@a8f54f7 was correct, but it looked like a typo since the names of the options are not consistent across versions - the best option for fixing this seems to be to support both options - we don't want to stop supporting `control` in the cli for backwards-compatibility so it is deprecated
|
Can this be merged? |
Add support for --control-url
--control--control-urlcontrol-clioption. On puma it is calledcontrolcontrolin the cli for backwards-compatibility