Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid option: --control-url #1477

Closed
sigmike opened this issue Nov 30, 2017 · 12 comments
Closed

invalid option: --control-url #1477

sigmike opened this issue Nov 30, 2017 · 12 comments
Labels

Comments

@sigmike
Copy link

sigmike commented Nov 30, 2017

Steps to reproduce

  1. Install puma 3.11.0

  2. Create a config with only activate_control_app 'unix:///tmp/puma.sock'

  3. Run pumactl -F <config file> start

Expected behavior

Starting an complaining about application not configured.

Actual behavior

invalid option: --control-url
/home/mike/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/puma-3.11.0/lib/puma/cli.rb:47:in `initialize'
/home/mike/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/puma-3.11.0/lib/puma/control_cli.rb:258:in `new'
/home/mike/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/puma-3.11.0/lib/puma/control_cli.rb:258:in `start'
/home/mike/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/puma-3.11.0/lib/puma/control_cli.rb:223:in `run'
/home/mike/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/puma-3.11.0/bin/pumactl:8:in `<top (required)>'
/home/mike/.rbenv/versions/2.4.2/bin/pumactl:23:in `load'
/home/mike/.rbenv/versions/2.4.2/bin/pumactl:23:in `<main>'

System configuration

Ruby version: 2.4.2
Rails version: N/A
Puma version: 3.11.0

Comments

Seems to be caused by commit 459ab19

Puma 3.10.0 works fine.

@crevete
Copy link

crevete commented Nov 30, 2017

I've got the same issue and go back to 3.10 as workaround for now.

@jlduran
Copy link

jlduran commented Dec 6, 2017

459ab19

@jxa
Copy link
Contributor

jxa commented Dec 15, 2017

I get the same. The problem stems from an option mismatch between pumactl and puma cli. On puma cli the option is --control and in pumactl the option is called control-url.

Putting together a PR as soon as I figure out how to write a test for this.

@chickenham
Copy link

I noticed that a new version of puma was released but this is still not fixed. Is this going to be fixed at some point - or is there a workaround?

@jdoss
Copy link

jdoss commented Mar 6, 2018

This is a blocker on us upgrading Puma as well.

@jxa
Copy link
Contributor

jxa commented Mar 6, 2018

#1487 is a fix, but I need some help getting the new test to pass on CI. If anyone has advice or the time to look into it I'd appreciate the help.

@puma puma deleted a comment from crevete Mar 19, 2018
@puma puma deleted a comment from crevete Mar 19, 2018
edwardloveall added a commit to edwardloveall/pullfeed that referenced this issue Apr 12, 2018
This seems to be a bug they're working on: puma/puma#1477
@crevete
Copy link

crevete commented May 22, 2018

@nateberkopec Why did you delete my comment ? Can you please explain me why you continue to release new versions without fixing this blocker issue ?

@frankpinto
Copy link

Just ran into this myself while upgrading from Upstart in Puma 14.04 to 16.04 and wanting to use pumactl start as the ExecStart. Any updates?

@jxa
Copy link
Contributor

jxa commented Jun 27, 2018

The fix is merged to master but not in time for the latest release. It would be really swell if they did a bugfix release for this issue.

What do you think @schneems ?

@schneems
Copy link
Contributor

I have another metric I want to expose via Puma.stats probably next week. I’m fine if this goes out before then though.

@schneems
Copy link
Contributor

schneems commented Jul 21, 2018

I cut a release can this Issue be closed?

@sigmike
Copy link
Author

sigmike commented Jul 26, 2018

Yes it's fixed in 3.12.0. Thank you.

@sigmike sigmike closed this as completed Jul 26, 2018
edwardloveall added a commit to edwardloveall/portfolio that referenced this issue Jul 29, 2018
A new version was shipped and so I should be able to use the latest
version of puma

puma/puma#1477
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants