Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RACK_ENV set and not loading correct config/puma/ENV.rb file #1447

Closed
allaire opened this issue Nov 2, 2017 · 3 comments
Closed

RACK_ENV set and not loading correct config/puma/ENV.rb file #1447

allaire opened this issue Nov 2, 2017 · 3 comments
Labels

Comments

@allaire
Copy link
Contributor

allaire commented Nov 2, 2017

Steps to reproduce

  1. Set a configuration file in config/puma/development.rb using different thread values

  2. Run RACK_ENV=development puma start

  3. Notice that the thread counts are not the one you've set in the config

  4. Run puma -e development and it should work

Expected behavior

I think puma should respect the RACK_ENV and load the correct environment config file.

We can read in the README:

If no configuration file is specified, Puma will look for a configuration file at config/puma.rb. If an environment is specified, either via the -e and --environment flags, or through the RACK_ENV environment variable, the default file location will be config/puma/environment_name.rb.

System configuration

Ruby version: 2.3.1
Rails version: 5.1 stable
Puma version: 3.10

@ViliusLuneckas
Copy link
Contributor

Hi @allaire, could you try version 3.11. I think the fix (#1340) was released with that version.

@allaire
Copy link
Contributor Author

allaire commented Nov 21, 2017

@ViliusLuneckas I'll try to repro on 3.11, but we switched to a single config file, with some if/else around the RACK_ENV

@nateberkopec
Copy link
Member

(Marking as fixed, please re-open if it isn't)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants