Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add msys2_mingw_dependencies to puma.gemspec #1434

Merged
merged 1 commit into from Oct 10, 2017
Merged

Add msys2_mingw_dependencies to puma.gemspec #1434

merged 1 commit into from Oct 10, 2017

Conversation

jumbosushi
Copy link
Contributor

Add a line to puma.gemspec as specified in #1428

@juliancheal
Copy link
Contributor

@jumbosushi aw you beat me to it.
screen shot 2017-10-10 at 22 39 26

juliancheal
juliancheal reviewed Oct 10, 2017
View reviewed changes
puma.gemspec Outdated
@@ -17,5 +17,6 @@ Gem::Specification.new do |s|
%w[History.md LICENSE README.md]
s.homepage = "http://puma.io"
s.license = "BSD-3-Clause"
s.metadata["msys2_mingw_dependencies"] = "openssl"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be better on line 16 underneath s.extensions = ["ext/puma_http11/extconf.rb"] seems to be more related to extensions than homepage & license

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just changed it to your way. I wasn't 100% sure about where to put the line so this was helpful. Thanks for the tip!

@jumbosushi jumbosushi force-pushed the add-win-runbyinstaller2-builds branch from 91d6b8f to 0d13f18 Compare October 10, 2017 21:46
@nateberkopec nateberkopec merged commit 41bd8d5 into puma:master Oct 10, 2017
@luislavena luislavena mentioned this pull request Oct 10, 2017
Merged
nateberkopec pushed a commit that referenced this pull request Oct 11, 2017
@luislavena @nateberkopec
gemspec: correct msys2 metadata typo (#1436)
47eaf00 
To help out RubyInstaller2 and provide hints to MSYS2 about required
dependencies, `msys2_mingw_dependencies` metadata was added to the
gemspec.

This change aims to correct the typo around the new metadata field.

Ref #1434
Ref #1428
This was referenced Mar 12, 2021
Closed
Open
Merged
Closed
Closed
Closed
Open
Open
Closed
Closed
Merged
Closed
Open
Merged
Open
@sync-by-unito sync-by-unito bot mentioned this pull request Apr 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliancheal juliancheal juliancheal left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jumbosushi @juliancheal @nateberkopec