Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puma/launcher: Fixed typo #1429

Merged
merged 1 commit into from Oct 9, 2017
Merged

puma/launcher: Fixed typo #1429

merged 1 commit into from Oct 9, 2017

Conversation

perlun
Copy link
Contributor

@perlun perlun commented Oct 5, 2017

I noted this while trying to apply suggestions from #1363.

The previous example causes exceptions when you try to run it:

FATAL [2017-10-05 11:11:17.535] UxFactory::Server: A fatal error occurred. Details below.
FATAL [2017-10-05 11:11:17.535] UxFactory::Server: no implicit conversion of Puma::Events into Array (TypeError)
        /Users/plundberg/.rvm/gems/ruby-2.4.2/gems/puma-3.10.0/lib/puma/launcher.rb:370:in `generate_restart_data'
        /Users/plundberg/.rvm/gems/ruby-2.4.2/gems/puma-3.10.0/lib/puma/launcher.rb:64:in `initialize'
        /Volumes/extra/git/ecraft/ecraft.uxfactory.server-8.x/src/server/lib/server/uxfactory_server.rb:32:in `new'
        /Volumes/extra/git/ecraft/ecraft.uxfactory.server-8.x/src/server/lib/server/uxfactory_server.rb:32:in `start_server'
        /Volumes/extra/git/ecraft/ecraft.uxfactory.server-8.x/src/server/lib/server/uxfactory_server.rb:15:in `start'
        /Volumes/extra/git/ecraft/ecraft.uxfactory.server-8.x/src/uxfactory/server.rb:69:in `block in start!'

I noted this while trying to apply suggestions from #1363.
@nateberkopec nateberkopec merged commit 70f309b into puma:master Oct 9, 2017
@perlun perlun deleted the patch-1 branch October 10, 2017 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants