Control CLI Bug Fix #1416
Merged
Control CLI Bug Fix #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
jxa
added a commit
to jxa/puma
that referenced
this pull request
Dec 15, 2017
- puma#1416 introduced a bug in pumactl the puma cli does not respond to `control-cli` option. On puma it is called `control` - this commit puma@a8f54f7 was correct, but it looked like a typo since the names of the options are not consistent across versions - the best option for fixing this seems to be to support both options in the cli - we don't want to stop supporting `control` in the cli for backwards-compatibility - should pumactl be extended to support `control`? we don't need to worry about backwards compatibility for this one, but it could cause some confusion -[] test
jxa
added a commit
to jxa/puma
that referenced
this pull request
Jan 7, 2018
- deprecate `--control` - add new option `--control-url` - puma#1416 introduced a bug in pumactl the puma cli does not respond to `control-cli` option. On puma it is called `control` - this commit puma@a8f54f7 was correct, but it looked like a typo since the names of the options are not consistent across versions - the best option for fixing this seems to be to support both options in the cli - we don't want to stop supporting `control` in the cli for backwards-compatibility so it is deprecated
This was referenced Mar 15, 2018
jxa
added a commit
to jxa/puma
that referenced
this pull request
Apr 12, 2018
- deprecate `--control` - add new option `--control-url` - puma#1416 introduced a bug in pumactl the puma cli does not respond to `control-cli` option. On puma it is called `control` - this commit puma@a8f54f7 was correct, but it looked like a typo since the names of the options are not consistent across versions - the best option for fixing this seems to be to support both options in the cli - we don't want to stop supporting `control` in the cli for backwards-compatibility so it is deprecated
jxa
added a commit
to jxa/puma
that referenced
this pull request
Apr 13, 2018
- deprecate `--control` - add new option `--control-url` - puma#1416 introduced a bug in pumactl the puma cli does not respond to `control-cli` option. On puma it is called `control` - this commit puma@a8f54f7 was correct, but it looked like a typo since the names of the options are not consistent across versions - the best option for fixing this seems to be to support both options - we don't want to stop supporting `control` in the cli for backwards-compatibility so it is deprecated
nateberkopec
pushed a commit
that referenced
this pull request
May 9, 2018
- deprecate `--control` - add new option `--control-url` - #1416 introduced a bug in pumactl the puma cli does not respond to `control-cli` option. On puma it is called `control` - this commit a8f54f7 was correct, but it looked like a typo since the names of the options are not consistent across versions - the best option for fixing this seems to be to support both options - we don't want to stop supporting `control` in the cli for backwards-compatibility so it is deprecated
This was referenced Mar 12, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per recent comments on this commit and a request by @nateberkopec on Twitter, this PR addresses a bug that was in control-cli.
The commit is fairly self explanatory, but there was an error in adding in the control-url arg. This PR fixes that typo.