Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement rfc2324 section 2.3.2, Status 418: I'm a teapot. #1392

Merged
merged 1 commit into from Aug 11, 2017
Merged

Implement rfc2324 section 2.3.2, Status 418: I'm a teapot. #1392

merged 1 commit into from Aug 11, 2017

Conversation

hoffm
Copy link
Contributor

@hoffm hoffm commented Aug 11, 2017

@nateberkopec
Copy link
Member

Linking #1133, because we've have to add 418 back when importing the stdlib's status codes.

@hoffm
Copy link
Contributor Author

hoffm commented Aug 11, 2017

@nateberkopec The Lord's work is never done.

@nateberkopec
Copy link
Member

Merging this, because at least one Ruby web framework supports 418, so if they send down a 418 via Rack we want to append the correct message. Our HTTP status code hash should basically reflect whatever the popular frameworks will send down to us. (I'm not going to just add everything Hanami does though, they've got a few in there that actually conflict with current IANA codes, e.g. 451: https://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml)

This change has been made to ensure the highest standards of scalability, accuracy and reliability in teapot deliverability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants