Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not blow up when RUBYOPT is not defined #1385

Merged
merged 1 commit into from Aug 16, 2017

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Aug 5, 2017

tried to run from master ... kaboom :D

NoMethodError: undefined method `include?' for nil:NilClass
  puma-0d7a8bb5f377/lib/puma/launcher.rb:171:in `run'

@grosser
Copy link
Contributor Author

grosser commented Aug 5, 2017

@nateberkopec

@stereobooster
Copy link
Contributor

I suppose this PR shadows this one https://github.com/puma/puma/pull/1348/files.

@grosser
Copy link
Contributor Author

grosser commented Aug 5, 2017 via email

@nateberkopec
Copy link
Member

Yeah, this looks like it does the same thing as #1348 with a much smaller change.

@grosser why don't we .dup ORIGINAL_ENV

@grosser
Copy link
Contributor Author

grosser commented Aug 16, 2017

added .dup for good measure ... might have produced weird errors if someone shells our from a puma process

@nateberkopec nateberkopec merged commit aa16777 into puma:master Aug 16, 2017
dekellum added a commit to dekellum/lionfish that referenced this pull request Aug 16, 2017
This reverts commit 853c01d.

No longer needed with fix on puma master

github: puma/puma#1344 puma/puma#1385
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants