New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix environment file loader #1340
Fix environment file loader #1340
Conversation
Environment could be a String or Proc
Tests are failing. Does your branch based on latest master? |
@stereobooster, I forked puma more than a month ago when the master was failing. Merging latest commits from the master, tests should pass now. |
This looks green and master builds green, are there any blockers to merging this change? |
What's the relationship of this change to this change which closed that issue which this PR wants to fix? |
@nateberkopec Can you re-review this change, now that it's green? |
This PR should fix #1327 issue.
Could someone tell me if we need this kind of backward compatibility or just CLI test misuse configuration protocol?