Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix environment file loader #1340

Merged
merged 8 commits into from Oct 16, 2017

Conversation

ViliusLuneckas
Copy link
Contributor

This PR should fix #1327 issue.

Could someone tell me if we need this kind of backward compatibility or just CLI test misuse configuration protocol?

@stereobooster
Copy link
Contributor

Tests are failing. Does your branch based on latest master?

@ViliusLuneckas
Copy link
Contributor Author

@stereobooster, I forked puma more than a month ago when the master was failing. Merging latest commits from the master, tests should pass now.

@olleolleolle
Copy link
Contributor

This looks green and master builds green, are there any blockers to merging this change?

@olleolleolle
Copy link
Contributor

What's the relationship of this change to this change which closed that issue which this PR wants to fix?

0584a33

@ViliusLuneckas
Copy link
Contributor Author

This PR fixes the process which loads puma config file based on RACK_ENV. The issue is well written in #1327. Meanwhile 0584a33 fixes some local problem which might or not be fixed with this PR. To be honest – no idea 😕

@olleolleolle
Copy link
Contributor

@nateberkopec Can you re-review this change, now that it's green?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading environment file is broken since 3.8.0
4 participants