Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1214 Puma >= 3.6.1 + SSL + Persistent Connections. Puma Hangs :( #1334

Merged
merged 1 commit into from Jun 13, 2017

Conversation

respire
Copy link
Contributor

@respire respire commented Jun 13, 2017

#1214
master one

@etscrivner
Copy link

Can confirm that this is an issue, and has been blocking an upgrade for some time.

@evanphx
Copy link
Member

evanphx commented Jun 13, 2017

I'm not sure how this fixes it, you appear to have removed the code that runs the data through the SSL engine.

@evanphx
Copy link
Member

evanphx commented Jun 13, 2017

Oh, nevermind. readnonblock is running it through as expected.

@evanphx evanphx merged commit 63f3c51 into puma:master Jun 13, 2017
@vincentwoo
Copy link

would really love a new version cut with this fix! Puma is hard to use in dev with SSL currently.

@vincentwoo
Copy link

Hi @evanphx, sorry to nag, but I really think it'd be great to get a new Puma version out with this fix.

@nateberkopec
Copy link
Member

Release is blocked on #1344

@vincentwoo
Copy link

Is there any chance we can get a release cut without #1344? This one seems quite serious in comparison.

@nateberkopec
Copy link
Member

No. I'm not going to release something I know is broken. You can use master branch.

@respire respire deleted the fix_minissl_socket_blocking_close branch November 15, 2017 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants