[display] Overwrite terminal contents #11695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of clearing the contents of the display with each frame, overwrite its contents by clearing to the end of each line prior to a newline. This should eliminate flickering in the interactive display. This also eliminates a couple of off-by-one errors that were hampering usability.
Changelog[uncommitted] (2022-12-20)Bug Fixes
|
|
There are three commits here. The first contains the actual changes, the second updates the baselines, and the third contains the changelog. |
|
Building and running locally to get an idea of the change. |
Hiding the cursor should eliminate the last of the redraw artifacts.
|
Added one more commit that hides the cursor in the interactive display, which should eliminate the last of the redraw artifacts. |
If you have a service dev stack, refreshing that stack is an excellent case study. |
AaronFriel
approved these changes
Dec 20, 2022
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of clearing the contents of the display with each frame,
overwrite its contents by clearing to the end of each line prior to a
newline. This should eliminate flickering in the interactive display.
This also eliminates a couple of off-by-one errors that were hampering
usability.
Fixes #11691, https://github.com/pulumi/customer-support/issues/837.