Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpret schema.Asset as pcl.AssetOrArchive #11593

Merged
merged 1 commit into from Dec 8, 2022

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Dec 8, 2022

Fixes #11572

@iwahbe iwahbe self-assigned this Dec 8, 2022
@pulumi-bot
Copy link
Contributor

Changelog

[uncommitted] (2022-12-08)

Bug Fixes

  • [programgen] Interpret schema.Asset as pcl.AssetOrArchive.
    #11593

Copy link
Contributor

@Zaid-Ajaj Zaid-Ajaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@iwahbe
Copy link
Member Author

iwahbe commented Dec 8, 2022

bors r+

bors bot added a commit that referenced this pull request Dec 8, 2022
11589: Don't use `*schema.Package` in nodejs codegen r=iwahbe a=iwahbe

Part of #9932
Builds on #11578

tldr: Package is not reliable when its used for an external package. We are transferring over to PackageReference, and will remove the Package field once all references to it have been removed.

11592: Don't use `*schema.Package` in .NET codegen r=iwahbe a=iwahbe

Part of #9932
Builds on #11578

tldr: Package is not reliable when its used for an external package. We are transferring over to PackageReference, and will remove the Package field once all references to it have been removed.

11593: Interpret schema.Asset as pcl.AssetOrArchive r=iwahbe a=iwahbe

Fixes #11572

Co-authored-by: Ian Wahbe <ian@wahbe.com>
@bors
Copy link
Contributor

bors bot commented Dec 8, 2022

Build failed (retrying...):

@bors
Copy link
Contributor

bors bot commented Dec 8, 2022

Build succeeded:

@bors bors bot merged commit 43cfc49 into master Dec 8, 2022
@bors bors bot deleted the iwahbe/11572/interpret-schema.Asset-as-AssetOrArchive branch December 8, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PCL Type check of Asset doesn't match with generated SDK
4 participants