Rotate cloud secrets provider #11554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zaid-Ajaj
reviewed
Dec 15, 2022
pkg/cmd/pulumi/util.go
Outdated
| @@ -190,14 +190,15 @@ func createSecretsManager( | |||
| } | |||
|
|
|||
| if secretsProvider == passphrase.Type { | |||
| if _, pharseErr := filestate.NewPassphraseSecretsManager(stack.Ref().Name(), configFile, | |||
| rotatePassphraseSecretsProvider); pharseErr != nil { | |||
| if _, pharseErr := filestate.NewPassphraseSecretsManager(stack.Ref().Name(), | |||
There was a problem hiding this comment.
Did you mean phraseErr here?
There was a problem hiding this comment.
Hah I mean I didn't change that text, but yes I'm sure that's what the original author intended. I'll fix it up.
Zaid-Ajaj
approved these changes
Dec 15, 2022
Frassle
force-pushed
the
fraser/rotateCloudSecrets
branch
from
41f267d
to
c6fd8f4
Compare
Changelog[uncommitted] (2022-12-15)Features
|
Frassle
force-pushed
the
fraser/rotateCloudSecrets
branch
from
c6fd8f4
to
d94470a
Compare
Frassle
force-pushed
the
fraser/rotateCloudSecrets
branch
from
d94470a
to
1d1fe80
Compare
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Little thing I noticed while looking at secrets. We support the idea of rotating the passphrase secret provider (that is changing the key and assigning a new passphrase). Turns out this makes sense for the cloud secret provider as well where we generate a new symmetric key.
Checklist
make changelogand committed thechangelog/pending/<file>documenting my change