Fix capitalization for generated fs.readdirSync
#11478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2022-11-28)Bug Fixes
|
aq17
approved these changes
Nov 28, 2022
|
bors r+ |
Zaid-Ajaj
reviewed
Nov 28, 2022
| @@ -66,13 +66,12 @@ var PulumiPulumiProgramTests = []ProgramTest{ | |||
| { | |||
| Directory: "aws-s3-folder", | |||
| Description: "AWS S3 Folder", | |||
| ExpectNYIDiags: allProgLanguages.Except("go"), | |||
| SkipCompile: allProgLanguages.Except("dotnet"), | |||
| ExpectNYIDiags: codegen.NewStringSet("dotnet", "python"), | |||
There was a problem hiding this comment.
ExpectNYI was only for go but now also for dotnetand python? The equivalent in dotnet is a simple function Directory.EnumerateFiles from the System.IO namespace
There was a problem hiding this comment.
Oh nevermind, I read that incorrectly 😓 my bad
|
Build failed: |
|
bors retry |
|
Build failed: |
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us reenable the
"aws-s3-folder"programgen test for nodejs.