Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulumi destroy --remove command deletes stack config file #11394

Merged
merged 2 commits into from Dec 13, 2022

Conversation

heagma
Copy link
Contributor

@heagma heagma commented Nov 17, 2022

Description

pulumi destroy --remove command now will delete also the stack config file. This will be consistent with pulumi stack rm

Fixes #11198

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@github-actions
Copy link

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

  • /run-acceptance-tests - used to test run the acceptance tests for the project
  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

@pulumi-bot
Copy link
Contributor

pulumi-bot commented Nov 17, 2022

Changelog

[uncommitted] (2022-12-13)

Features

  • [cli] pulumi destroy --remove will now delete the stack config file

@iwahbe
Copy link
Member

iwahbe commented Nov 22, 2022

/run-acceptance-tests
Please view the results of the acceptance tests Here

@heagma
Copy link
Contributor Author

heagma commented Nov 24, 2022

@iwahbe looks like the pipeline is failing for the acceptance test against this template -> kubernetes-azure-yaml/Pulumi.yaml

@iwahbe
Copy link
Member

iwahbe commented Nov 25, 2022

Thanks @heagma. That was an unrelated error. Rerunning the tests should see that resolved.

@iwahbe
Copy link
Member

iwahbe commented Nov 25, 2022

/run-acceptance-tests
Please view the results of the acceptance tests Here

@iwahbe iwahbe self-requested a review November 25, 2022 02:00
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks short and sweet. Thanks for the contribution.

@iwahbe
Copy link
Member

iwahbe commented Nov 25, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 25, 2022

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@AaronFriel
Copy link
Member

/rebase

@AaronFriel
Copy link
Member

bors merge

@bors
Copy link
Contributor

bors bot commented Dec 13, 2022

Build succeeded:

@bors bors bot merged commit 53c4457 into pulumi:master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pulumi destroy --remove removes the stack, but not the stack config
4 participants