Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type check resource attributes #11371

Merged
merged 1 commit into from Nov 16, 2022
Merged

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Nov 16, 2022

Type check resource attributes unless instructed otherwise.

This makes debugging programgen errors so much easier!

@iwahbe iwahbe self-assigned this Nov 16, 2022
@pulumi-bot
Copy link
Contributor

Changelog

[uncommitted] (2022-11-16)

Bug Fixes

  • [programgen] Enable type checking for resource attributes
    #11371

Fix assets-archives-pp test so it type checks

Skip type checking on 2 transpiled tests

- azure-app-service
- aws-static-website
@iwahbe iwahbe force-pushed the iwahbe/type-check-resource-attributes branch from 914d95d to 0d3fca4 Compare November 16, 2022 02:46
@iwahbe
Copy link
Member Author

iwahbe commented Nov 16, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 16, 2022

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

bors bot added a commit that referenced this pull request Nov 16, 2022
11371: Type check resource attributes r=iwahbe a=iwahbe

Type check resource attributes unless instructed otherwise.

This makes debugging programgen errors so much easier!

Co-authored-by: Ian Wahbe <ian@wahbe.com>
@bors
Copy link
Contributor

bors bot commented Nov 16, 2022

Build failed:

@iwahbe
Copy link
Member Author

iwahbe commented Nov 16, 2022

bors retry

@bors
Copy link
Contributor

bors bot commented Nov 16, 2022

Build succeeded:

@bors bors bot merged commit 6f21c0d into master Nov 16, 2022
@bors bors bot deleted the iwahbe/type-check-resource-attributes branch November 16, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants