Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental use plan option to up #11353

Merged
merged 1 commit into from Nov 22, 2022
Merged

Add experimental use plan option to up #11353

merged 1 commit into from Nov 22, 2022

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Nov 15, 2022

Description

Adds an option to use plans in the update prompt:

Do you want to perform this update?  [Use arrows to move, type to filter]
> [experimental] yes, using Update Plans (https://pulumi.com/updateplans)
  yes
  no
  details

Needs at least pulumi/pulumi-hugo#2230 merged and published first.

Fixes #9687

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@pulumi-bot
Copy link
Contributor

pulumi-bot commented Nov 15, 2022

Changelog

[uncommitted] (2022-11-22)

Features

  • [cli] Add prompt to up to use experimental update plans.
    #11353

pkg/backend/apply.go Outdated Show resolved Hide resolved
@Frassle Frassle force-pushed the fraser/updatePlanPrompt branch 2 times, most recently from 64b79cd to dae818a Compare November 15, 2022 12:02
pkg/backend/apply.go Outdated Show resolved Hide resolved
pkg/backend/apply.go Outdated Show resolved Hide resolved
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinvp
Copy link
Member

bors merge

bors bot added a commit that referenced this pull request Nov 22, 2022
11353: Add experimental use plan option to up r=justinvp a=Frassle

<!--- 
Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation.
-->

# Description

<!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. -->
Adds an option to use plans in the update prompt:
```
Do you want to perform this update?  [Use arrows to move, type to filter]
> [experimental] yes, using Update Plans (https://pulumi.com/updateplans)
  yes
  no
  details
```

Needs at least pulumi/pulumi-hugo#2230 merged and published first.

Fixes #9687

## Checklist

<!--- Please provide details if the checkbox below is to be left unchecked. -->
- [ ] I have added tests that prove my fix is effective or that my feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the Pulumi Service,
then the service should honor older versions of the CLI where this change would not exist.
You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version
  <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. -->


Co-authored-by: Fraser Waters <fraser@pulumi.com>
@bors
Copy link
Contributor

bors bot commented Nov 22, 2022

Build failed:

@justinvp
Copy link
Member

bors retry

@bors
Copy link
Contributor

bors bot commented Nov 22, 2022

Build succeeded:

@bors bors bot merged commit 6c046a9 into master Nov 22, 2022
@pulumi-bot pulumi-bot deleted the fraser/updatePlanPrompt branch November 22, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option during interactive "up" to use update plans
3 participants