Add default dependencies for {.NET,nodejs} #11315
Conversation
Changelog[uncommitted] (2022-11-10)Features
|
iwahbe
force-pushed
the
iwahbe/default-dependencies
branch
from
65fefda
to
4988626
Compare
iwahbe
force-pushed
the
iwahbe/default-dependencies
branch
from
4988626
to
791c3a9
Compare
iwahbe
force-pushed
the
iwahbe/default-dependencies
branch
from
791c3a9
to
5fa6b0f
Compare
iwahbe
force-pushed
the
iwahbe/default-dependencies
branch
from
5fa6b0f
to
7c4bfa1
Compare
|
bors r+ |
|
Build failed: |
|
bors retry |
|
Build succeeded: |
| packageReferences = map[string]string{} | ||
| } | ||
| if _, ok := packageReferences["Pulumi"]; !ok { | ||
| packageReferences["Pulumi"] = "3.*" |
There was a problem hiding this comment.
Is this reference accurate - is the latest code that gets generated compatible with Pulumi 3.0.0 or should this be something like [3.2.1,4)?
There was a problem hiding this comment.
@iwahbe sorry I wasn't able to review before this got merged ... might require a little more investigation and a follow-up PR
There was a problem hiding this comment.
No problem. We have 3.* everywhere. Checking against our examples, we compile against 3.23.
There was a problem hiding this comment.
Yeah, this is known to be wrong everywhere currently, but maintaining accurate min versions in each repo right now would be too much work. Now this is centralised, we should be bumping the min version as we add features to the SDK for use in codegen. We should do a one-off check if there have been any features added in the .Net SDK which are required for the current version of codegen.
11322: Set minimum .NET build version to 3.23.0 r=iwahbe a=iwahbe Followup on #11315 (comment). Co-authored-by: Ian Wahbe <ian@wahbe.com>
Fixes #11241
Fixes #11237