Disable auto stack parenting #11272
Merged
Disable auto stack parenting #11272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2022-11-07)Bug Fixes
|
Frassle
force-pushed
the
fraser/disableParents
branch
from
b3b65e5
to
64eb33c
Compare
Frassle
added
the
p1
AaronFriel
reviewed
Nov 7, 2022
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "go.buildTags": "all,smoke", | |||
| "go.buildTags": "all", | |||
There was a problem hiding this comment.
Oh this makes sense, since the tests are !smoke. Whoops.
There was a problem hiding this comment.
I just got fed up of having to change this all the time to be able to run tests in vscode, I don't think it will have affected CI in any way.
AaronFriel
reviewed
Nov 7, 2022
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Might fix #10950, but I've not been able to reproduce that bug so this is just a best guess.
Checklist
make changelogand committed thechangelog/pending/<file>documenting my change