Allow case insensitive prop typecheck on traversal #11266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2022-11-08)Features
|
|
Can this not be kept in as a tfgen specific thing? I've been talking to @danielrbradley about strengthening our case sensitivity in core codegen, not keen on weakening it. |
|
So after some internal talk on this, I'm fine with this change. We shouldn't be case-sensitive anyway (We support VB for example which can't distinguish between "Foo" and "foo") but we'll probably loop back to this in the future and might make it be strictly all lower case, rather than case-insensitive. |
AaronFriel
reviewed
Nov 8, 2022
changelog/pending/20221108--pkg--allow-case-insensitive-prop-typecheck-on-traversal.yaml
Outdated
Show resolved
Hide resolved
AaronFriel
approved these changes
Nov 8, 2022
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses some errors in #11070
Checklist
make changelogand committed thechangelog/pending/<file>documenting my change