[color] Use graphemes to measure strings. #11202
Conversation
Changelog[uncommitted] (2022-11-09)Bug Fixes
|
|
Stacks on top of #11201 |
pgavlin
force-pushed
the
pgavlin/measure-graphemes
branch
7 times, most recently
from
652e057
to
221795e
Compare
pgavlin
force-pushed
the
pgavlin/measure-graphemes
branch
2 times, most recently
from
dfacf7e
to
955e04c
Compare
The number of Unicode code points in a string is not the same as the number of user-visible characters (graphemes). When measuring colorized strings, we want the latter rather than the former. Notably, these changes fix some issues where the interactive display cut off before the right edge of the terminal.
pgavlin
force-pushed
the
pgavlin/measure-graphemes
branch
from
955e04c
to
3aecebe
Compare
| <{%reset%}> <{%reset%}> │ ├─ awsx:x:ec2:NatGateway vpc-0 <{%reset%}><{%reset%}> | ||
| <{%reset%}> <{%reset%}> │ │ └─ aws:ec2:Eip vpc-0 <{%reset%}><{%reset%}> | ||
| <{%reset%}> <{%reset%}> │ ├─ awsx:x:ec2:Subnet vpc-public-0 <{%reset%}><{%reset%}> | ||
| <{%reset%}> <{%reset%}> │ │ └─ aws:ec2:RouteTable vpc-public-0 <{%reset%}><{%reset%}> |
There was a problem hiding this comment.
Nit: It looks like we can optimize out a colorized column of length 0 and elide it.
To elaborate on these issues: In the interactive display, resources are rendered in a tree view with visible edges from children to parents. Each of these edges is formed using Unicode Box Drawing characters. These characters are outside the ASCII range, and each of their UTF-8 code units consists of three bytes. The code in the colorizer that clamps the output of colorization to a particular width was using byte counts instead of code points or graphemes. With these changes, these measurements are now done using graphemes (i.e. user-visible characters). |
| <{%reset%}> <{%reset%}> ├─ aws:ec2:SecurityGroupRule cluster-eksNodeClusterIngressRule <{%reset%}><{%reset%}> | ||
| <{%reset%}> <{%reset%}> ├─ kubernetes:core/v1:ConfigMap cluster-nodeAccess <{%reset%}><{%reset%}> | ||
| <{%reset%}> <{%reset%}> ├─ aws:ec2:LaunchConfiguration cluster-nodeLaunchConfiguration <{%reset%}><{%reset%}> | ||
| <{%bold%}><{%fg 3%}>~ <{%reset%}> └─ aws:cloudformation:Stack cluster-nodes <{%bold%}><{%fg 3%}>updating<{%reset%}><{%bold%}><{%fg 3%}><{%reset%}> |
There was a problem hiding this comment.
Kudos: Having snapshot based tests for display logic make reviewing these PRs much easier. 👍
|
bors merge |
11202: [color] Use graphemes to measure strings. r=pgavlin a=pgavlin The number of Unicode code points in a string is not the same as the number of user-visible characters (graphemes). When measuring colorized strings, we want the latter rather than the former. Notably, these changes fix some issues where the interactive display cut off before the right edge of the terminal. Co-authored-by: Pat Gavlin <pat@pulumi.com>
|
Timed out. |
|
bors retry |
|
Build succeeded: |
The number of Unicode code points in a string is not the same as the
number of user-visible characters (graphemes). When measuring colorized
strings, we want the latter rather than the former. Notably, these
changes fix some issues where the interactive display cut off before the
right edge of the terminal.