Add debug GRPC interceptors that print conversations in JSON #11085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2022-11-08)Features
|
AaronFriel
requested changes
Oct 19, 2022
t0yv0
force-pushed
the
t0yv0/grpc-trace
branch
2 times, most recently
from
84af240
to
77c7894
Compare
|
@Frassle @AaronFriel I've cleaned this up a bit:
The changes should be to my knowledge fully bw-compat, only affecting things when PULUMI_DEBUG_GRPC is set. |
t0yv0
force-pushed
the
t0yv0/grpc-trace
branch
from
3c6e71e
to
909672a
Compare
t0yv0
force-pushed
the
t0yv0/grpc-trace
branch
from
1e7c1a0
to
f31c5fd
Compare
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Nov 8, 2022
11085: Add debug GRPC interceptors that print conversations in JSON r=t0yv0 a=t0yv0 <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> Fixes #10232 `PULUMI_DEBUG_GRPC=./debug.json pulumi preview` now works. The debug APIs are probably unstable so I moved them out to their own repo rather than hosting under sdk/. Debug interceptors are no-op unless the process initializes them in main. Currently only `pulumi` process initializes them if the env var is set. This way we observe conversations only once, as a server for ResourceMonitor etc, and as a client for plugin conversations (language and resource). I can now see provider conversations logged which was of interest to me. ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Service, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Anton Tayanovskyy <anton.tayanovskyy@gmail.com> Co-authored-by: Anton Tayanovskyy <anton@pulumi.com>
|
Build failed: |
t0yv0
force-pushed
the
t0yv0/grpc-trace
branch
from
f31c5fd
to
9276574
Compare
|
bors merge |
|
Build succeeded: |
abhinav
pushed a commit
to pulumi/pulumi-dotnet
that referenced
this pull request
Jan 11, 2023
11085: Add debug GRPC interceptors that print conversations in JSON r=t0yv0 a=t0yv0 <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> Fixes pulumi/pulumi#10232 `PULUMI_DEBUG_GRPC=./debug.json pulumi preview` now works. The debug APIs are probably unstable so I moved them out to their own repo rather than hosting under sdk/. Debug interceptors are no-op unless the process initializes them in main. Currently only `pulumi` process initializes them if the env var is set. This way we observe conversations only once, as a server for ResourceMonitor etc, and as a client for plugin conversations (language and resource). I can now see provider conversations logged which was of interest to me. ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Service, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Anton Tayanovskyy <anton.tayanovskyy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10232
PULUMI_DEBUG_GRPC=./debug.json pulumi previewnow works.The debug APIs are probably unstable so I moved them out to their own repo rather than hosting under sdk/.
Debug interceptors are no-op unless the process initializes them in main. Currently only
pulumiprocess initializes them if the env var is set. This way we observe conversations only once, as a server for ResourceMonitor etc, and as a client for plugin conversations (language and resource).I can now see provider conversations logged which was of interest to me.
Checklist
make changelogand committed thechangelog/pending/<file>documenting my change