Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code coverage error should not fail a build #9730

Closed
mikhailshilkov opened this issue May 30, 2022 · 2 comments · Fixed by #9948
Closed

Code coverage error should not fail a build #9730

mikhailshilkov opened this issue May 30, 2022 · 2 comments · Fixed by #9948
Assignees
@RobbieMcKinstry
Labels
area/build CI/CD for pulumi/pulumi kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed size/S Estimated effort to complete (1-2 days).
Milestone
0.74

Comments

@mikhailshilkov
Copy link
Member

Failures like this one: https://github.com/pulumi/pulumi/runs/6614209710?check_suite_focus=true#step:40:25

image

should not fail the whole build.
@mikhailshilkov mikhailshilkov added area/build CI/CD for pulumi/pulumi kind/engineering Work that is not visible to an external user labels May 30, 2022
@RobbieMcKinstry
Copy link
Contributor

I had this same bug with a personal project just last week (though I didn't get to the bottom of it). I suspect "fail CI if error" is the config toggle we want, at the Action level.

@mikhailshilkov mikhailshilkov added this to the 0.74 milestone Jun 7, 2022
@RobbieMcKinstry RobbieMcKinstry self-assigned this Jun 7, 2022
@RobbieMcKinstry RobbieMcKinstry mentioned this issue Jun 23, 2022
Closed
@RobbieMcKinstry
Copy link
Contributor

I submitted an upstream PR to solve the issue we encountered.
TL;DR: GH Action inputfail_ci_on_error wasn't respected in some instances.

I'm going to move this issue in the tracker to "blocked" since we're awaiting PR review.

@RobbieMcKinstry RobbieMcKinstry added blocked size/S Estimated effort to complete (1-2 days). labels Jun 23, 2022
@RobbieMcKinstry RobbieMcKinstry mentioned this issue Jun 23, 2022
Merged
3 tasks
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobbieMcKinstry RobbieMcKinstry

Labels
area/build CI/CD for pulumi/pulumi kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed size/S Estimated effort to complete (1-2 days).
Projects
None yet
Milestone
0.74
Development

Successfully merging a pull request may close this issue.

Update Codecov action to v3 pulumi/pulumi
3 participants
@mikhailshilkov @RobbieMcKinstry @pulumi-bot