Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript program has invalid imports. #8063

Closed
iwahbe opened this issue Sep 27, 2021 · 1 comment
Closed

typescript program has invalid imports. #8063

iwahbe opened this issue Sep 27, 2021 · 1 comment
Assignees
Labels
area/codegen SDK-gen, program-gen, convert kind/bug Some behavior is incorrect or out of spec language/javascript resolution/fixed This issue was fixed

Comments

@iwahbe
Copy link
Member

iwahbe commented Sep 27, 2021

This was discovered compiling our program generator tests. We generate the import statement import * from "fs";. This should be import * as fs from "fs";.

Steps to reproduce

  1. cd pkg/codegen
  2. tsc --noEmit internal/test/testdata/aws-s3-folder-pp/aws-s3-folder.ts
    Note: this path is only valid after iwahbe/7802/compile program generator test output #8036 lands. Before that, the file can be found in internal/test/testdata
    Expected: Clean compile
    Actual:
internal/test/testdata/aws-s3-folder-pp/aws-s3-folder.ts(3,10): error TS1005: 'as' expected.
internal/test/testdata/aws-s3-folder-pp/aws-s3-folder.ts(3,15): error TS1005: 'from' expected.
internal/test/testdata/aws-s3-folder-pp/aws-s3-folder.ts(12,73): error TS1005: ';' expected.
internal/test/testdata/aws-s3-folder-pp/aws-s3-folder.ts(17,29): error TS1005: '{' expected.
internal/test/testdata/aws-s3-folder-pp/aws-s3-folder.ts(17,108): error TS1005: ';' expected.
@iwahbe iwahbe added kind/bug Some behavior is incorrect or out of spec area/codegen SDK-gen, program-gen, convert labels Sep 27, 2021
@iwahbe
Copy link
Member Author

iwahbe commented Nov 28, 2022

This looks like it has since been fixed. Test is reenabled in #11478.

@iwahbe iwahbe added the resolution/fixed This issue was fixed label Nov 28, 2022
@iwahbe iwahbe self-assigned this Nov 28, 2022
@iwahbe iwahbe closed this as completed Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/codegen SDK-gen, program-gen, convert kind/bug Some behavior is incorrect or out of spec language/javascript resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

1 participant