Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pulumi up tree view broken when exceeding console height #5441

Closed
stohrendorf opened this issue Sep 22, 2020 · 4 comments
Closed

pulumi up tree view broken when exceeding console height #5441

stohrendorf opened this issue Sep 22, 2020 · 4 comments
Labels
area/cli UX of using the CLI (args, output, logs) impact/usability Something that impacts users' ability to use the product easily and intuitively kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@stohrendorf
Copy link

The pulumi up tree view of the resources breaks when its height exceeds the console height (see screenshot).

Expected Behavior

Tree view is not broken.

Current Behavior

image

Steps to Reproduce

Add more resources than the height of the console can handle.

Context (Environment)

N/A

(Quick idea how to "fix" this - if possible: collapse child nodes if needed and limit vertical size of children in case of a flat list/degenerated tree and only show the full tree after planning is done.)
@stohrendorf stohrendorf added the needs-triage Needs attention from the triage team label Sep 22, 2020
@stack72 stack72 added area/cli UX of using the CLI (args, output, logs) impact/usability Something that impacts users' ability to use the product easily and intuitively and removed needs-triage Needs attention from the triage team labels Sep 22, 2020
@stohrendorf
Copy link
Author

FYI, this also affects pulumi preview so that it outputs wrong information. In certain cases it can output a valid looking tree that's not actually representing the actual resource tree. Both are ways to review the changes to be done, and as they can produce wrong outputs, possibly leading to a faulty stack update because of misinformation, I would consider this a bug.

@infin8x infin8x added the kind/bug Some behavior is incorrect or out of spec label May 3, 2021
@komalali komalali self-assigned this Jul 21, 2021
@komalali komalali added this to the 0.59 milestone Jul 21, 2021
@komalali komalali removed their assignment Jul 23, 2021
@komalali komalali removed this from the 0.59 milestone Jul 23, 2021
@SharpEdgeMarshall
Copy link

On big projects this is quite annoying, there is some workaround in the meantime?

@Frassle
Copy link
Member

Frassle commented Jan 18, 2022

I do wonder if it's worth investigating the use of something like tview for UI support.

@lukehoban lukehoban added the resolution/fixed This issue was fixed label Dec 30, 2022
@lukehoban
Copy link
Member

This was fixed in #11200.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/cli UX of using the CLI (args, output, logs) impact/usability Something that impacts users' ability to use the product easily and intuitively kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@lukehoban @stack72 @infin8x @Frassle @SharpEdgeMarshall @stohrendorf @komalali